Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor plotly integration, remove express, run testing with jest #2

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

ngfelixl
Copy link
Owner

@ngfelixl ngfelixl commented Feb 15, 2019

Add window resize event listener. Plots now react to browser resizing. Refactored web server. Remove mocha and chai and use jest instead. Copies plotly.min.js and types to project build from node_modules.

Closes #1

@coveralls
Copy link

coveralls commented Feb 16, 2019

Pull Request Test Coverage Report for Build 61

  • 61 of 85 (71.76%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-24.6%) to 73.333%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plot.ts 16 18 88.89%
src/server.ts 44 66 66.67%
Totals Coverage Status
Change from base Build 31: -24.6%
Covered Lines: 61
Relevant Lines: 85

💛 - Coveralls

@ngfelixl ngfelixl force-pushed the test-with-jest branch 7 times, most recently from 11cf453 to 4211981 Compare February 16, 2019 12:26
Plots now react to browser resizing. Refactored web server.
Remove mocha and chai and use jest instead.
Copies plotly.min.js and types to project build from node_modules.
@ngfelixl ngfelixl merged commit 2713673 into master Feb 16, 2019
@ngfelixl ngfelixl deleted the test-with-jest branch September 9, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants